Use the passed service account for worker deployments #20342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This account will have the pull secret available and will also be a single point for users to make changes in Kubernetes RBAC if they need to enforce more strict control over the application's permissions.
|
Checked commit carbonin@f080605 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
Jansa pods PR: ManageIQ/manageiq-pods#580 |
simaishi
pushed a commit
that referenced
this pull request
Jul 9, 2020
Use the passed service account for worker deployments (cherry picked from commit 48a3eac)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This account will have the pull secret available and will also
be a single point for users to make changes in Kubernetes RBAC
if they need to enforce more strict control over the application's
permissions.
Merge with ManageIQ/manageiq-pods#579
Will need a separate jansa PR for ManageIQ/manageiq-pods#579 so I'll mark this for jansa once that's at least opened.