Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings.docs - move from ui, add documentation link & setting #20320

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Settings.docs - move from ui, add documentation link & setting #20320

merged 1 commit into from
Jun 30, 2020

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Jun 30, 2020 •
edited
Loading

Move Settings.docs settings from the UI (merge this before ManageIQ/manageiq-ui-classic#7162),
fix http -> https,

and add product_documentation_direct_link and product_documentation_website settings to fix ManageIQ/manageiq-documentation#557

Cc @Fryguy

@himdel
Settings.docs - move from ui, add documentation link & setting
2286986 
move Settings.docs settings from the UI,

fix http -> https,

add product_documentation_direct_link and product_documentation_website.
@himdel himdel requested a review from jrafanie as a code owner June 30, 2020 19:25
This was referenced Jun 30, 2020
Merged
Closed
@miq-bot
Copy link
Member

miq-bot commented Jun 30, 2020

Checked commit https://github.com/himdel/manageiq/commit/2286986eabcfab4ba40ed42f88ddf722b757d93b with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy Fryguy merged commit 90a056c into ManageIQ:master Jun 30, 2020
@Fryguy Fryguy self-assigned this Jun 30, 2020
@himdel himdel deleted the settings branch June 30, 2020 20:08
simaishi pushed a commit that referenced this pull request Jul 1, 2020
@Fryguy @simaishi
Merge pull request #20320 from himdel/settings
6f7ae2c 
Settings.docs - move from ui, add documentation link & setting

(cherry picked from commit 90a056c)
@simaishi
Copy link
Contributor

simaishi commented Jul 1, 2020

Jansa backport details:

$ git log -1
commit 6f7ae2c2bc2c43ae283837835cb4bd944687ef5b
Author: Jason Frey <[email protected]>
Date:   Tue Jun 30 15:55:54 2020 -0400

    Merge pull request #20320 from himdel/settings

    Settings.docs - move from ui, add documentation link & setting

    (cherry picked from commit 90a056c0401f29aa23b0525b283aa2116d669aea)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie Awaiting requested review from jrafanie jrafanie is a code owner

Assignees

@Fryguy Fryguy

Labels
enhancement jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation under Bell icon is not linked directly
5 participants
@himdel @miq-bot @simaishi @Fryguy @gtanzillo