Remove the miq_workers table from the reindex list #20305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing nearly constant deadlocks in an environment with lots of updates on the workers table. Based on https://www.postgresql.org/docs/10/sql-reindex.html it sounds like reindexes will definitely interfere with updates and that the situations where we actually need a reindex are rather rare. https://bugzilla.redhat.com/show_bug.cgi?id=1846281 Fixes ManageIQ#20281
|
Checked commit carbonin@1a005f4 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
jrafanie
approved these changes
Jun 24, 2020
I agree 👍 |
simaishi
pushed a commit
that referenced
this pull request
Jun 25, 2020
Remove the miq_workers table from the reindex list (cherry picked from commit 153932c)
|
Jansa backport details: |
|
@carbonin I assume this can be |
|
I don't see why not. Assuming this is in ivanchuk that is (I don't remember when we moved this into the app vs the console) |
simaishi
pushed a commit
that referenced
this pull request
Jul 1, 2020
Remove the miq_workers table from the reindex list (cherry picked from commit 153932c) https://bugzilla.redhat.com/show_bug.cgi?id=1846281
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing nearly constant deadlocks in an environment with
lots of updates on the workers table. Based on
https://www.postgresql.org/docs/10/sql-reindex.html it sounds like
reindexes will definitely interfere with updates and that the situations
where we actually need a reindex are rather rare.
https://bugzilla.redhat.com/show_bug.cgi?id=1846281
Fixes #20281
I'm actually okay with leaving this without a migration. My thought was that
if a user has changed the tables for a reindex then they would probably be
aware of this deadlock issue if they were hitting it.