Combine child managers' RefreshWorkers #20302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2020
agrare
added a commit
to agrare/manageiq-providers-amazon
that referenced
this pull request
Jun 23, 2020
agrare
added a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Jun 23, 2020
agrare
added a commit
to agrare/manageiq-cross_repo-tests
that referenced
this pull request
Jun 23, 2020
This was referenced Jun 23, 2020
Closed
agrare
changed the title
|
@agrare This PR is no longer WIP, but all the dependent PRs are still WIP. |
|
@chessbyte updated |
Providers with multiple managers shouldn't be refreshed by different workers. Most multi-manager providers already do this and the rest should.
agrare
force-pushed
the
standardize_combined_refresh_workers
branch
from
d9ecc63 to
0930319
Compare
|
Checked commit agrare@0930319 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint app/models/manageiq/providers/base_manager/refresh_worker.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providers with multiple managers shouldn't be refreshed by different workers. Most multi-manager providers already do this and the rest should.
This addresses point 1 of #19950
Cross Repo Tests: ManageIQ/manageiq-cross_repo-tests#145
Dependents: