Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the worker liveness check timeout to avoid false failures #20236

Merged

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Jun 2, 2020

In some environments I've seen this take over a second to complete.
It runs every 10 seconds so I figure 5 seconds is a fine time to wait.

In some environments I've seen this take over a second to complete.
It runs every 10 seconds so I figure 5 seconds is a fine time to wait.
@miq-bot
Copy link
Member

miq-bot commented Jun 2, 2020

Checked commit carbonin@4167dde with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@bdunne bdunne merged commit 9438f1a into ManageIQ:master Jun 3, 2020
simaishi pushed a commit that referenced this pull request Jun 5, 2020
…meout

Bump the worker liveness check timeout to avoid false failures

(cherry picked from commit 9438f1a)
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2020

Jansa backport details:

$ git log -1
commit 63a42ab69d8b716ac05c647fcb3aae316b4a47e2
Author: Brandon Dunne <[email protected]>
Date:   Wed Jun 3 09:51:01 2020 -0400

    Merge pull request #20236 from carbonin/bump_worker_liveness_check_timeout

    Bump the worker liveness check timeout to avoid false failures

    (cherry picked from commit 9438f1a7264ee668a57195fc5fee5c733ca63b23)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants