Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better formatting for rate columns in chargeback reports #20228

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Better formatting for rate columns in chargeback reports #20228

merged 1 commit into from
Jun 2, 2020

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jun 1, 2020

fixes #20138

Used Rate:
Screenshot 2020-06-01 at 14 10 53

Before

Screenshot 2020-06-01 at 14 15 59

After
Screenshot 2020-06-01 at 14 13 40

@miq-bot assign @gtanzillo
@miq-bot add_label chargeback, enhancement

@lpichler lpichler requested review from Fryguy and gtanzillo as code owners June 1, 2020 12:17
@miq-bot
Copy link
Member

miq-bot commented Jun 1, 2020

@lpichler Cannot apply the following label because they are not recognized:

  • chargeback

All labels for ManageIQ/manageiq: https://github.com/ManageIQ/manageiq/labels

@lpichler
Copy link
Contributor Author

lpichler commented Jun 1, 2020

@miq-bot add_label jansa/yes

@lpichler lpichler force-pushed the rate_column_formatting branch from 948ec34 to 4d970ca Compare June 1, 2020 12:46
@lpichler lpichler force-pushed the rate_column_formatting branch from 4d970ca to 3897ce5 Compare June 1, 2020 13:12
@miq-bot
Copy link
Member

miq-bot commented Jun 1, 2020

Checked commit lpichler@3897ce5 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

gtanzillo
gtanzillo approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@gtanzillo gtanzillo merged commit 0bf5d54 into ManageIQ:master Jun 2, 2020
@lpichler lpichler deleted the rate_column_formatting branch June 3, 2020 07:29
simaishi pushed a commit that referenced this pull request Jun 5, 2020
@gtanzillo @simaishi
Merge pull request #20228 from lpichler/rate_column_formatting
6fd3362 
Better formatting for rate columns in chargeback reports

(cherry picked from commit 0bf5d54)
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2020

Jansa backport details:

$ git log -1
commit 6fd33628539d675076ef91c6fcc097e058ea394b
Author: Gregg Tanzillo <[email protected]>
Date:   Tue Jun 2 17:09:14 2020 -0400

    Merge pull request #20228 from lpichler/rate_column_formatting

    Better formatting for rate columns in chargeback reports

    (cherry picked from commit 0bf5d54cfd86114ad4a2ad812f775fb1e0b1edc5)

@lpichler
Copy link
Contributor Author

@jvlcek

before
Screenshot 2020-06-10 at 12 55 39

after
Screenshot 2020-06-10 at 12 49 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@gtanzillo gtanzillo

Labels
core/chargeback enhancement jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chargeback report rates display needs better formatting
5 participants
@lpichler @miq-bot @simaishi @gtanzillo @chessbyte