Startpage url changes to go with non-explorer verison of CB Assignments #20192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
skateman
reviewed
May 20, 2020
db/fixtures/miq_shortcuts.yml
Outdated
| @@ -26,7 +26,7 @@ | |||
| :startup: true | |||
| - :name: chargeback_assignments | |||
| :description: Overview / Chargeback / Assignments | |||
| :url: /chargeback_assignments/explorer | |||
| :url: /chargeback_assignments/index | |||
There was a problem hiding this comment.
You don't need index, just remove the last / and everything after and it should work.
h-kataria
force-pushed
the
cb_assignments_startpage_update
branch
from
21870b0 to
f32ebc5
Compare
h-kataria
force-pushed
the
cb_assignments_startpage_update
branch
from
f32ebc5 to
d97ed24
Compare
skateman
reviewed
May 20, 2020
| @@ -26,7 +26,7 @@ | |||
| :startup: true | |||
| - :name: chargeback_assignments | |||
| :description: Overview / Chargeback / Assignments | |||
| :url: /chargeback_assignments/explorer | |||
| :url: /chargeback_assignment | |||
There was a problem hiding this comment.
Wait, why are we going to singular here?
There was a problem hiding this comment.
plural was a typo, it should have been a singular.
|
Checked commit h-kataria@d97ed24 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
bdunne
approved these changes
May 21, 2020
simaishi
pushed a commit
to simaishi/manageiq
that referenced
this pull request
May 28, 2020
…page_update Startpage url changes to go with non-explorer verison of CB Assignments (cherry picked from commit 64e4d4c)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI PR ManageIQ/manageiq-ui-classic#7049