MiqReport: add skip_references attribute back #20109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where serialized reports were reporting an error: ``` Error caught: [ActiveModel::UnknownAttributeError] unknown attribute 'skip_references' for MiqReport. ``` `skip_references` is no longer applicable. But some serialized reports may still reference it. This attribute has been added back in to avoid any issues. Fixes ManageIQ#20106
NickLaMuro
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Two things, but I think this change is fine:
Steps for Testing/QA
create a report with
db_options: skip_references
Should that be skip_references: true instead, so it is valid yaml?
Also, do we eventually want to add deprecation warnings around these attributes? Mostly just curious if we want to support these infinitely into the future or eventually drop them.
Anyway, I am good with the change. I like that it is really simple while keeping the code deletion of the previous effort. 👍
|
Tested this 👍 |
simaishi
pushed a commit
that referenced
this pull request
Apr 28, 2020
MiqReport: add skip_references attribute back (cherry picked from commit 0f49e31)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where serialized reports were reporting an error.
skip_references won't do anything, since the functionality has been
removed.
But this attribute is available so customer reports that have that
option don't blow up.
Fixes #20106
Steps for Testing/QA
create a report with
It should break before this change
It should work after this change