Server static assets in production based on environment detection

[Fryguy]

• Additionally adds tests for a number of environment conditions

@jrafanie please Review
cc @himdel

[Fryguy]

We can debate the name...I was having a hard time with this.

Note that in discussions with @simaishi, it might be preferable to have a dedicated ENV var for this, such as MANAGEIQ_IMAGE=true, which would be present in all build artifacts whether appliance, podified, or container. Then, this becomes a simple check for that ENV VAR, and all of the other checks in this file can use that value as a an extra sanity check.

[jrafanie]

If we honored RAILS_SERVE_STATIC_FILES's value, these types of installations can set this env variable and this method is not needed. Thoughts?

[Fryguy]

RAILS_SERVE_STATIC_FILES is meant for dev use case of testing locally when Rails.env == "production"...that is, devs are expected to set it. The rationale is that in production Rails static asset serving is off by default, and then you opt-in with the env var, so on real production you specifically don't set anything.

[Fryguy]

@jrafanie As discussed I've also added a warning output for the abnormal use cases so users know what is happening and aren't surprised.

[miq-bot]

Some comments on commits Fryguy/manageiq@40620c9~...cbc55d8

config/environments/production.rb

• ⚠️ - 18 - Detected puts. Remove all debugging statements.

[miq-bot]

Checked commits Fryguy/manageiq@40620c9~...cbc55d8 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
3 files checked, 2 offenses detected

config/environments/production.rb

• ❗ - Line 18, Col 3 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.

lib/miq_environment.rb

• ❗ - Line 27, Col 14 - Naming/PredicateName - Rename is_production_build? to production_build?.

[jrafanie]

Awesome. This is great. Knowing that rails is serving static assets in production mode is a nice addition as clearly, that's not a normal thing I do unless I'm doing performance testing of slow requests.

[simaishi]

Jansa backport details:

$ git log -1
commit 4247cbad85fe5cae1e809266f50100a144a15185
Author: Joe Rafaniello <[email protected]>
Date:   Fri May 15 15:14:03 2020 -0400

    Merge pull request #20107 from Fryguy/production_static_assets

    Server static assets in production based on environment detection

    (cherry picked from commit daa6751d737b4546716ae5ed9b547a8b1c727f3b)