Fix a bug when running Rbac on VimPerformanceDaily #20058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rbac.filtered(VimPerformanceDaily)` rendered the following:
```
Failure/Error: return klass.name[0..-12].constantize.base_class
NameError:
uninitialized constant VimPer
```
The problem was that it was saying that `VimPerformanceTag` has an associated with a class.
`VmPerformance` and `HostPerformance` have associated classes (`Vm` and `Host` respectively).
This code derives the associated code from the class name by
removing `"performance"` (11 letters) from the end.
But `VimPerformanceTag` is not associated with a model, so
stripping off the last 11 letters (which aren't the word performance)
|
Checked commit kbrock@048c861 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rbac.filtered(VimPerformanceDaily)rendered the following:The problem was that it was saying that
VimPerformanceTagruns the security off of an associated class.
VmPerformanceandHostPerformancehave associated classes:VmandHostrespectively.The code actually derives the associated code from the class name by
removing
"performance"(11 letters) from the end.But
VimPerformanceTagis not associated with a model, and the namedoes not end in
Performance. Unsurprisingly stripping off the last11 letters result in an error.