Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize_type_map now expects 1 argument #20030

Merged
merged 1 commit into from
Apr 1, 2020
Merged

initialize_type_map now expects 1 argument #20030

merged 1 commit into from
Apr 1, 2020

Conversation

jrafanie
Copy link
Member

Fixes:

4: from activerecord (5.2.3) lib/active_record/connection_adapters/postgresql_adapter.rb:48:in `new'
        3: from config/initializers/postgres_required_versions.rb:3:in `initialize'
        2: from activerecord (5.2.3) lib/active_record/connection_adapters/postgresql_adapter.rb:235:in `initialize'
        1: from lib/extensions/ar_types.rb:4:in `initialize_type_map'
ArgumentError (wrong number of arguments (given 0, expected 1))

The interface changed in rails 5.2. This change is backward compatible with rails 5.1.

@jrafanie
initialize_type_map now expects 1 argument
95a5db0 
Fixes:

4: from activerecord (5.2.3) lib/active_record/connection_adapters/postgresql_adapter.rb:48:in `new'
        3: from config/initializers/postgres_required_versions.rb:3:in `initialize'
        2: from activerecord (5.2.3) lib/active_record/connection_adapters/postgresql_adapter.rb:235:in `initialize'
        1: from lib/extensions/ar_types.rb:4:in `initialize_type_map'
ArgumentError (wrong number of arguments (given 0, expected 1))
@jrafanie
Copy link
Member Author

cc @kbrock

@miq-bot
Copy link
Member

miq-bot commented Mar 30, 2020

Checked commit jrafanie@95a5db0 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

lib/extensions/ar_types.rb

@chessbyte chessbyte mentioned this pull request Mar 31, 2020
Closed
38 tasks
@kbrock kbrock merged commit b677636 into ManageIQ:master Apr 1, 2020
@jrafanie jrafanie deleted the initialize_type_map_now_expects_1_argument branch April 1, 2020 16:17
@jrafanie
Copy link
Member Author

jrafanie commented Apr 2, 2020

@miq-bot add_label jansa/yes?

simaishi pushed a commit that referenced this pull request Apr 3, 2020
@kbrock @simaishi
Merge pull request #20030 from jrafanie/initialize_type_map_now_expec…
8d26583 
…ts_1_argument

initialize_type_map now expects 1 argument

(cherry picked from commit b677636)
@simaishi
Copy link
Contributor

simaishi commented Apr 3, 2020

Jansa backport details:

$ git log -1
commit 8d26583673d31c09e612f3280cf68fe1411531b3
Author: Keenan Brock <[email protected]>
Date:   Wed Apr 1 12:16:52 2020 -0400

    Merge pull request #20030 from jrafanie/initialize_type_map_now_expects_1_argument

    initialize_type_map now expects 1 argument

    (cherry picked from commit b677636c28d0c9a87e51a4406055f11f50796715)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

Assignees
No one assigned
Labels
jansa/backported rails5.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrafanie @miq-bot @simaishi @kbrock @gtanzillo