With rails 5.2, where clauses will no longer cast Class objects as Strings #20029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rings. We need to explicitly pass String objects. Similar to ManageIQ#19016 Fixes errors of this variety on rails 5.2 (in a rails 5.1 backward compatible way): ``` irb(main):001:0> MiqReportResult.with_chargeback The version of PostgreSQL being connected to is incompatible with ManageIQ (10 required) PostgreSQLAdapter#log_after_checkout, connection_pool: size: 5, connections: 1, in use: 1, waiting_in_queue: 0 Traceback (most recent call last): 16: from activerecord (5.2.4.2) lib/active_record/relation.rb:584:in `skip_query_cache_if_necessary ... 1: from activerecord (5.2.4.2) lib/active_record/connection_adapters/abstract/quoting.rb:34:in `rescue in type_cast' TypeError (can't cast Class) ```
|
cc @kbrock |
|
Checked commit jrafanie@17b0130 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
@miq-bot add_label jansa/yes? |
simaishi
pushed a commit
that referenced
this pull request
Apr 3, 2020
…_not_class_objects With rails 5.2, where clauses will no longer cast Class objects as Strings (cherry picked from commit 346956c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to explicitly pass String objects.
Similar to #19016
Fixes errors of this variety on rails 5.2 (in a rails 5.1 backward compatible
way):