Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kafka connection info to worker containers #20000

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add kafka connection info to worker containers #20000

merged 1 commit into from
Mar 30, 2020

Conversation

carbonin
Copy link
Member

@carbonin carbonin requested a review from Fryguy March 23, 2020 19:17
@carbonin carbonin requested a review from gtanzillo as a code owner March 23, 2020 19:17
@carbonin carbonin force-pushed the add_kafka_for_container_workers branch from 6f1b11a to 8d92f8c Compare March 23, 2020 19:42
@agrare agrare mentioned this pull request Mar 23, 2020
Merged
@carbonin carbonin force-pushed the add_kafka_for_container_workers branch from 8d92f8c to 75fdde0 Compare March 23, 2020 19:59
@miq-bot
Copy link
Member

miq-bot commented Mar 23, 2020

Checked commit carbonin@75fdde0 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@carbonin carbonin mentioned this pull request Mar 25, 2020
Closed
@bdunne bdunne merged commit 7cb5385 into ManageIQ:master Mar 30, 2020
simaishi pushed a commit that referenced this pull request Apr 16, 2020
@bdunne @simaishi
Merge pull request #20000 from carbonin/add_kafka_for_container_workers
ef6661d 
Add kafka connection info to worker containers

(cherry picked from commit 7cb5385)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit ef6661d5b722e444433792d3bcd24504e7aa0b1d
Author: Brandon Dunne <[email protected]>
Date:   Mon Mar 30 13:56:16 2020 -0400

    Merge pull request #20000 from carbonin/add_kafka_for_container_workers

    Add kafka connection info to worker containers

    (cherry picked from commit 7cb53851b26fa9fcad10338060ee31f7bc2acb7c)

@carbonin carbonin deleted the add_kafka_for_container_workers branch April 23, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

Assignees

@bdunne bdunne

Labels
core enhancement jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carbonin @miq-bot @simaishi @chessbyte @bdunne