Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SERVICE_ORDER_CLASS to a string #19951

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Change SERVICE_ORDER_CLASS to a string #19951

merged 1 commit into from
Mar 11, 2020

Conversation

gmcculloug
Copy link
Member

Hopefully avoiding the constant constant problem.

Related to:
#19795
#19944

@gmcculloug
Change SERVICE_ORDER_CLASS to a string
acfdfad 
Hopefully avoiding the constant constant problem.
@gmcculloug gmcculloug requested review from Fryguy and carbonin March 11, 2020 18:01
@gmcculloug gmcculloug requested a review from gtanzillo as a code owner March 11, 2020 18:01
@miq-bot
Copy link
Member

miq-bot commented Mar 11, 2020

Checked commit gmcculloug@acfdfad with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
5 files checked, 0 offenses detected
Everything looks fine. 👍

@carbonin carbonin self-assigned this Mar 11, 2020
@carbonin carbonin merged commit fbcce99 into ManageIQ:master Mar 11, 2020
simaishi pushed a commit that referenced this pull request Mar 20, 2020
@carbonin @simaishi
Merge pull request #19951 from gmcculloug/service_order_constant_problem
49e6e49 
Change SERVICE_ORDER_CLASS to a string

(cherry picked from commit fbcce99)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 49e6e498091142330b103acc2653e29eed333412
Author: Nick Carboni <[email protected]>
Date:   Wed Mar 11 14:46:52 2020 -0400

    Merge pull request #19951 from gmcculloug/service_order_constant_problem

    Change SERVICE_ORDER_CLASS to a string

    (cherry picked from commit fbcce99ccf1eb437204cf5edfe6b6df138982b46)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonin carbonin carbonin approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

Assignees

@carbonin carbonin

Labels
bug jansa/backported lifecycle/services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gmcculloug @miq-bot @simaishi @carbonin @chessbyte