Add missing script interpreters #19917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
|
@jrafanie this is ready for review |
|
@miq-bot remove_label wip |
|
@miq-bot add_label ivanchuk/yes |
I don't remember if github show file permissions but locally I get: diff --git a/tools/ci/after_failure.sh b/tools/ci/after_failure.sh
old mode 100644
new mode 100755
diff --git a/tools/ci/before_install.sh b/tools/ci/before_install.sh
old mode 100644
new mode 100755
diff --git a/tools/ci/setup_ruby_env.sh b/tools/ci/setup_ruby_env.sh
old mode 100644
new mode 100755
diff --git a/tools/ci/setup_vmdb_configs.sh b/tools/ci/setup_vmdb_configs.sh
old mode 100644
new mode 100755 |
|
yay, thanks for cleaning this up |
d-m-u
force-pushed
the
fixing_missing_script_interpreters
branch
from
4ee925c to
fec10db
Compare
|
whoa yeah it does: that's cool |
|
Checked commit d-m-u@fec10db with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
simaishi
pushed a commit
that referenced
this pull request
Mar 20, 2020
Add missing script interpreters (cherry picked from commit 6c5ee55) https://bugzilla.redhat.com/show_bug.cgi?id=1751248
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start to a bug where scripts in tools should have the interpreter set if they are executable.
For https://bugzilla.redhat.com/show_bug.cgi?id=1751248
the only three that clearly needed the line:
have it already set:
./copy_reports_structure.rb
./reset_admin_password.rb
aren't stand alone scripts, ergo shouldn't need the interpreter:
./collect_logs/exclude_files
./copy_reports_structure/report_structure.rb
./server_settings_replicator/server_settings_replicator.rb
./fix_auth/auth_config_model.rb
./fix_auth/auth_model.rb
./radar/rollup_radar_mixin.rb
./fix_auth/models.rb
./fix_auth/fix_auth.rb
./fix_auth/cli.rb
./miqldap_to_sssd/sssd_conf/sssd.rb
./miqldap_to_sssd/auth_establish.rb
./miqldap_to_sssd/auth_template_files.rb
./miqldap_to_sssd/configure_apache.rb
./miqldap_to_sssd/configure_appliance_settings.rb
./miqldap_to_sssd/configure_database.rb
./miqldap_to_sssd/configure_selinux.rb
./miqldap_to_sssd/configure_sssd_rules.rb
./pg_inspector/connection_locks.rb
./pg_inspector/error.rb
./pg_inspector/pg_inspector_operation.rb
./miqldap_to_sssd/miqldap_configuration.rb
./pg_inspector/servers_to_yaml.rb
./pg_inspector/active_connections_to_human.rb
./pg_inspector/active_connections_to_yaml.rb
./miqldap_to_sssd/sssd_conf/common.rb
./miqldap_to_sssd/sssd_conf/domain.rb
./miqldap_to_sssd/converter.rb
./miqldap_to_sssd/services.rb
./miqldap_to_sssd/sssd_conf/pam.rb
./miqldap_to_sssd/sssd_conf/ifp.rb
./miqldap_to_sssd/sssd_conf.rb
./pg_inspector/util.rb
./miqldap_to_sssd/cli.rb
./pg_inspector/cli.rb
completed in a removal:
./migrate_policies (#19918)
./classify_vms_by_folder (#19923)
moved:
./radar/rollup_radar_mixin_spec.rb (#19926)
It's LJ's party:
@miq-bot assign @jrafanie
@miq-bot add_label bug