Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The api calls exec_api_call directly from Api::Mixins::CentralAdmin #19892

Merged
merged 1 commit into from
Feb 28, 2020
Merged

The api calls exec_api_call directly from Api::Mixins::CentralAdmin #19892

merged 1 commit into from
Feb 28, 2020

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Feb 28, 2020 •
edited
Loading

Fixes broken master on ManageIQ/api

Cross-repo tests: ManageIQ/manageiq-cross_repo-tests#79

@miq-bot
Copy link
Member

miq-bot commented Feb 28, 2020

Checked commit bdunne@975e90a with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

jrafanie
jrafanie approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when cross repo is green. Thanks @bdunne

@jrafanie jrafanie merged commit c8938e4 into ManageIQ:master Feb 28, 2020
@jrafanie jrafanie added this to the Sprint 131 Ending Mar 2, 2020 milestone Feb 28, 2020
@bdunne bdunne deleted the api_require branch February 28, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

@agrare agrare Awaiting requested review from agrare agrare is a code owner

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@kbrock kbrock Awaiting requested review from kbrock kbrock is a code owner

Assignees

@jrafanie jrafanie

Labels
api bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdunne @miq-bot @jrafanie