[V2V] Use two-phase migration only for warm migration #19880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit fabiendupont@62ee3db with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
djberg96
approved these changes
Feb 27, 2020
agrare
approved these changes
Feb 27, 2020
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Feb 27, 2020
[V2V] Use two-phase migration only for warm migration (cherry picked from commit 91176bd) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1808069
|
Ivanchuk backport details: |
simaishi
added a commit
that referenced
this pull request
Mar 9, 2020
|
Reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two-phase migration changes the migration flow in virt-v2v-wrapper: the disks are created by virt-v2v-wrapper and attached to the conversion host. Then, the conversion phase writes to local disks instead of using RHV upload API. This converges the processes for RHV and OpenStack, and can involve performance increase.
However, currently virt-v2v-wrapper only allows two-phase for warm migration, so we need to limit it. In a previous PR, we anticipated too much to availability for cold migration, so we introduced a regression with current version of virt-v2v-wrapper (2.0.x). This PR ties two-phase and warm migration.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1807770