Delay load manageiq-api-client until needed #19860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need to add a require in the test too. I guess the other ruby version passed because the gem was already required by a previous test. |
jrafanie
force-pushed
the
delay_load_api_client
branch
from
b3f9575 to
cecc74e
Compare
jrafanie
requested review from
agrare,
Fryguy,
gtanzillo and
kbrock
as code owners
We can require this when needed instead of eager loading it when Vm or other models load it.
jrafanie
force-pushed
the
delay_load_api_client
branch
from
cecc74e to
973a3a7
Compare
|
Checked commit jrafanie@973a3a7 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can require this when needed instead of eager loading it when Vm or other
models load it.