Consolidate existing server setting CLI tools

[d-m-u]

We don't have current functionality for setting a server setting once for all servers.
It's probably all going to be wrong, but we have to start somewhere.

I'll link the issue when I'm more sure that this is the right approach _{^{which honestly might not be ever}} — as Joe said, the downside of this is that it requires that we push out this server setting change for each new server added to an environment.

[d-m-u]

@miq-bot assign @jrafanie

[jrafanie]

The thing about this approach is it's a net +3 lines in the existing script and we get to delete the old script. I don't see any feature we lose. The only downside is we aren't setting it at a zone/region level, so you need to do it for any new servers but that was the case for the old script.

We should link to #19747 and have @evertmulder review this to ensure it handles the existing use cases. Also, is the issue you were trying to fix in #19441 also a problem with this PR's approach?

[d-m-u]

@evertmulder any chance you might be able to address #19848 (comment) please?

[d-m-u]

@miq-bot add_label enhancement

[Fryguy]

Why does this set it server by server as opposed to setting it at the region level once?

[d-m-u]

Because I liked option two better: #19747 (comment)

[Fryguy]

I don't like option 2 specifically because it doesn't account for new servers. The only con there that seems to make sense is that you have to deal with servers that have the value already overwritten, but that is handled already via the magic settings keywords (I think it's <enforce>, but I'd have to check)

EDIT: The magic value is <<reset>> and you would apply it to each server to tell it to inherit a value. I thought there was a method or something to enforce the value top-down, but I can't find it offhand.

[jrafanie]

I don't like option 2 specifically because it doesn't account for new servers.

It's replacing tools/server_settings_replicator/server_settings_replicator.rb , which also didn't account for new servers, and the code added was so trivial, I was fine with doing this for now especially due to the following...

The only con there that seems to make sense is that you have to deal with servers that have the value already overwritten, but that is handled already via the magic settings keywords (I think it's <enforce>, but I'd have to check)

Are you able to edit/view settings for region/zone in the UI/api? For example, if you blasted a value for a region/zone and wanted to confirm it in the UI/api, I'm not sure if that's easy to do. I know it works in the backend but if it's not in the UI/api, it might make sense to do a more equivalent replacement script while we determine what's missing in the region/zone settings work.

[Fryguy]

Are you able to edit/view settings for region/zone in the UI/api?

Yes. You can view and edit the settings at any level. API can also do it at any level.

[jrafanie]

Are you able to edit/view settings for region/zone in the UI/api?

Yes. You can view and edit the settings at any level. API can also do it at any level.

TMYK. Cool. I'll have to review it with @d-m-u @yrudman as I think he implemented some of it. I'm not sure how to view settings at the region/zone level.

Before this PR, we had 2 scripts saving server based settings:

tools/server_settings_replicator/server_settings_replicator.rb
tools/configure_server_settings.rb

After this PR, we have most if not all of the former's features by adding 3 lines to the latter. I question if we should first deprecate the former script but nevertheless, it's a surgical replacement.

We can implement blasting region/zone settings later on to solve the problem of having to update settings to new servers but my hope was first to remove the nearly duplicate script first. Also, region/zone settings isn't a direct replacement of the former script so I thought this would be easier to take in steps.

[miq-bot]

Checked commit d-m-u@c60d50c with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
1 file checked, 1 offense detected

tools/configure_server_settings.rb

• ❗ - Line 87, Col 5 - Style/StderrPuts - Use warn instead of STDERR.puts to allow such output to be disabled.

[jrafanie]

Add first pass at setting global server settings

Maybe let's rename this PR to "Consolidate existing server setting CLI tools". This PR's intention was to de-duplicate our existing scripts down to one tool to set server settings. It doesn't prevent us from adding zone/region setting support.

[jrafanie]

Merging. This PR consolidates 2 scripts that set server settings into 1 by adding 3 whole lines to the existing script. While region/zone settings are possible in the future, it's outside the scope of this PR and far more complicated than 3 lines of code.

[d-m-u]

@miq-bot add_label jansa/yes

[simaishi]

Jansa backport details:

$ git log -1
commit 4c90e011031726f0bd979713fa514b51599a4682
Author: Joe Rafaniello <[email protected]>
Date:   Fri Mar 27 09:56:59 2020 -0400

    Merge pull request #19848 from d-m-u/adding_option_to_copy_server_settings_pass_one

    Consolidate existing server setting CLI tools

    (cherry picked from commit 7f454fc8b0fa8949df7b5de7b370b29cbc097a26)