Fix the RegistrationSystem spec #19806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AwesomeSpawn::CommandResultError expects an AwesomeSpawn::CommandResult argument to `#initailize` not a string. This spec was stubbing the `LinuxAdmin::SubscriptionManager#organizations` method and raising an exception with a string instead of a CommandResult.
|
Some comments on commit agrare@b8e02e3 spec/models/registration_system_spec.rb
|
|
Checked commit agrare@b8e02e3 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
reviewed
Feb 4, 2020
| @@ -38,7 +38,7 @@ | |||
| end | |||
|
|
|||
| it "with invalid credentials" do | |||
| expect_any_instance_of(LinuxAdmin::SubscriptionManager).to receive(:organizations).once.and_raise(LinuxAdmin::CredentialError, "Invalid username or password") | |||
| expect_any_instance_of(LinuxAdmin::SubscriptionManager).to receive(:organizations).once.and_raise(LinuxAdmin::CredentialError, AwesomeSpawn::CommandResult.new("command_line", "Invalid username or password", "Invalid username or password", 1)) | |||
There was a problem hiding this comment.
I think this output is only on stderr
Merged
simaishi
pushed a commit
that referenced
this pull request
Feb 4, 2020
Fix the RegistrationSystem spec (cherry picked from commit 2e03a3b)
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Feb 6, 2020
Fix the RegistrationSystem spec (cherry picked from commit 2e03a3b)
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AwesomeSpawn::CommandResultError expects an AwesomeSpawn::CommandResult
argument to
#initailizenot a string.LinuxAdmin correctly passes the result to the exception: https://github.com/ManageIQ/linux_admin/blob/master/lib/linux_admin/registration_system/subscription_manager.rb#L8
This spec was stubbing the
LinuxAdmin::SubscriptionManager#organizationsmethod and raising anexception with a string instead of a CommandResult.
This was changed by ManageIQ/awesome_spawn#39 which was committed a while ago but only recently released.