Use the server's zone to determine a node selector when running in pods #19789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
force-pushed
the
add_node_selector_for_zone
branch
from
18be768 to
07c0356
Compare
carbonin
commented
Feb 4, 2020
carbonin
commented
Feb 4, 2020
This will allow workers to be target to specific nodes.
carbonin
force-pushed
the
add_node_selector_for_zone
branch
from
afd2ad2 to
dbb28af
Compare
carbonin
changed the title
|
Cross repo tests ManageIQ/manageiq-cross_repo-tests#62 |
chessbyte
reviewed
Feb 5, 2020
carbonin
commented
Feb 5, 2020
We auto-create a server per zone so a change should never be necessary
This tells the UI if we're currently able/allowed to change the zone of servers
This will prevent database access every time we call this method and we're not running in pods.
This will allow us to include a node in multiple zones for more flexibility.
carbonin
force-pushed
the
add_node_selector_for_zone
branch
from
dbb28af to
1a5f85b
Compare
Without this change we get errors from Kube about the label format: $> oc label node node.example.com manageiq/zone/asdf=true The Node "node.example.com" is invalid: metadata.labels: Invalid value: "manageiq/zone/asdf": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')
|
Checked commits carbonin/manageiq@c5e7d98~...c9015dc with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/zone.rb
|
Fryguy
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow workers to be target to specific nodes.
This works for now, but I haven't looked into what happens if a server changes zones. Leaving this as WIP until I get around to that.As a part of this I added a validation to fail updates to a server's zone in pods. Additionally I created a UI PR to disable the zone drop-down for pods and handle validation errors when changing the server zone.
Fixes ManageIQ/manageiq-pods#353