Remove process_messages_from_server from MiqWorker #19788
Conversation
The process_messages_from_server method was last used by the MiqVimBrokerWorker and can be removed now.
| @@ -298,15 +296,6 @@ def heartbeat | |||
| do_exit("Error heartbeating because #{err.class.name}: #{err.message}\n#{err.backtrace.join('\n')}", 1) | |||
| end | |||
|
|
|||
| def process_messages_from_server | |||
| worker_monitor_drb.register_worker(@worker.pid, @worker.class.name, @worker.queue_name) | |||
There was a problem hiding this comment.
I think we may still need this call.
This is what adds the worker info to the server hash for fetching queue messages.
There was a problem hiding this comment.
Should that live in the queue_worker then? I don't think non-queue workers need that
There was a problem hiding this comment.
That's part of what it does. This also ensures that the worker is present in the server's worker's cache. It's not all that straight forward unfortunately, but now that the messages bit is gone we can unravel it in a follow-up, but for this first pass I think we should probably just keep this around.
There was a problem hiding this comment.
Okay, that means that run_single_worker will still fail if the miq_server isn't running (aka testing out a single worker) can we try to handle that case also?
|
Damn. A bit late. |
|
I'll open a separate PR to fix. |
The process_messages_from_server method was last used by the
MiqVimBrokerWorker and can be removed now.
ManageIQ/manageiq-providers-vmware#484