Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify_credentials_task to host #19775

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 28, 2020

This adds a way for the UI/API to queue a verify_credentials call for a
host rather than calling it directly.

@agrare
Copy link
Member Author

agrare commented Jan 28, 2020

WIP pending specs, cc @himdel

@agrare
Copy link
Member Author

agrare commented Jan 28, 2020

If we get hosts to be able to support similar DDF schema as an EMS we can standardize on the verify_credentials_mixin here but I don't want to hold off on getting the UI to use this interface for that

@miq-bot miq-bot added the wip label Jan 28, 2020
This adds a way for the UI/API to queue a verify_credentials call for a
host rather than calling it directly.
@agrare agrare force-pushed the add_verify_credentials_task_to_host branch from dc6fe01 to 447dde4 Compare January 28, 2020 19:16
@agrare agrare changed the title [WIP] Add verify_credentials_task to host Add verify_credentials_task to host Jan 28, 2020
@agrare agrare removed the wip label Jan 28, 2020
@miq-bot
Copy link
Member

miq-bot commented Jan 28, 2020

Checked commit agrare@447dde4 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

spec/models/host_spec.rb

@gtanzillo gtanzillo self-assigned this Jan 28, 2020
@gtanzillo gtanzillo added this to the Sprint 129 Ending Feb 3, 2020 milestone Jan 28, 2020
@gtanzillo gtanzillo merged commit 5a86129 into ManageIQ:master Jan 28, 2020
@agrare agrare deleted the add_verify_credentials_task_to_host branch January 28, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants