Fixing unknown unknowns #19774
Merged
Fixing unknown unknowns #19774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
probably_bad_log_timestamp_fix
branch
7 times, most recently
from
f1ce070 to
a89402b
Compare
d-m-u
changed the title
d-m-u
force-pushed
the
probably_bad_log_timestamp_fix
branch
6 times, most recently
from
f7777ea to
b82f372
Compare
d-m-u
changed the title
jrafanie
reviewed
Jan 28, 2020
jrafanie
reviewed
Jan 28, 2020
d-m-u
force-pushed
the
probably_bad_log_timestamp_fix
branch
from
b82f372 to
35e696d
Compare
jrafanie
reviewed
Jan 29, 2020
d-m-u
force-pushed
the
probably_bad_log_timestamp_fix
branch
2 times, most recently
from
c43129f to
62cf888
Compare
jrafanie
reviewed
Jan 29, 2020
d-m-u
force-pushed
the
probably_bad_log_timestamp_fix
branch
from
62cf888 to
1c796d2
Compare
d-m-u
force-pushed
the
probably_bad_log_timestamp_fix
branch
from
1c796d2 to
a4a3ba8
Compare
|
Checked commit d-m-u@a4a3ba8 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
The entire quote is 🥇 . English at it's finest. |
jrafanie
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automate model and dialog collection logfile thingy doesn't have the timestamp set and so the names look like
Dialogs_region_0_default_2_EVM_1_unknown_unknown.zip.We could just set it to now for the automate and model things and not have 🎉 unknown unknowns 🎉 .
Something like this could fix https://bugzilla.redhat.com/show_bug.cgi?id=1706989 maybe possibly, I dunno.
@miq-bot assign @jrafanie
@miq-bot add_label bug
I am almost too young to be making that reference anyway I was barely alive for that