Map server to zone in pods #19770
Merged
Map server to zone in pods #19770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to manage servers when running in containers. Without this change a user would be stuck with a single server and would not be able to make use of the features that zones provide.
This will be used by the UI instead of their current, separate logic
In specs we often will create a server, which creates a zone for us in the factory. Previously, even when we were simulating running in pods, that would leave us with one server and one zone. Now, the zone creation process is checking the environment for podified and creating a server itself. This leaves us with an extra call to MiqEnvironment::Command.is_podified and some bonus server records. This commit handles both of those issues.
carbonin
force-pushed
the
map_server_to_zone_in_pods
branch
from
d27d378 to
3fdfb86
Compare
|
Cross repo test for UI PR and API ManageIQ/manageiq-cross_repo-tests#58 |
|
Checked commits carbonin/manageiq@eaf2420~...3fdfb86 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/zone.rb
|
|
@h-kataria Do you know why the UI blocks deletion of Zones when schedules are attached? |
Fryguy
approved these changes
Jan 30, 2020
|
As far as I could tell it was added in commit 2170f15bd09d4fe69fd3759e00dcc5b87e4096c6 (2013) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to zones and servers to make them easier to manage in pods.
Automatically create a server when a zone is created and delete the servers in a zone when a zone is deleted. This also requires toning down the restrictions on deleting servers and zones.
While testing this change I found that the UI has separate logic to determine when a zone is able to be deleted. This PR also consolidates that logic with the most important change that we're allowing a zone to be deleted if it has schedules associated with it. Previously the UI prevented the delete if schedules were present, but the model didn't check for that and, in fact, has a
:dependent_destroyon the relation.Applies to ManageIQ/manageiq-pods#353