Remove storage references to multiple emses #19754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Jan 27, 2020
agrare
reviewed
Jan 27, 2020
app/models/storage.rb
Outdated
|
|
||
| def ext_management_systems_with_authentication_status_ok_in_zone(zone_name) | ||
| ext_management_systems_with_authentication_status_ok.select { |ems| ems.my_zone == zone_name } | ||
| [ext_management_system] |
There was a problem hiding this comment.
Maybe .compact to handle the case of an archived storage
agrare
reviewed
Jan 27, 2020
app/models/storage.rb
Outdated
| ems = emss.detect { |e| smartstate_analysis_count_for_ems_id(e.id) < ::Settings.storage.max_parallel_scans_per_ems } | ||
| if ems.nil? | ||
| ems = ext_management_system | ||
| unless smartstate_analysis_count_for_ems_id(e.id) < ::Settings.storage.max_parallel_scans_per_ems |
There was a problem hiding this comment.
was this supposed to be ems.id or is e defined somewhere else?
agrare
reviewed
Jan 27, 2020
|
Looks good @kbrock, few comments and the specs are failing |
Storage now uses ems_id instead of host_storages for ems references ManageIQ#19617 This further makes that change
kbrock
force-pushed
the
storage_ems_id
branch
from
8dc30be to
ab68c94
Compare
|
Checked commit kbrock@ab68c94 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Fixing ui specs in ManageIQ/manageiq-ui-classic#6662, that's dead as well, right? |
|
@himdel we left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up technical debt in the storage to ems link.
There is a bit of cruft in the code to support a storage belonging to multiple emses. These optimizations were introduced to fix some performance issues with refresh.
Now that
Storagehas a single ems (viaems_id) instead of going throught thehost_storagesreference, these optimizations can be removed.The PR that moved towards
ems_id-- #19617