Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back some missing state transitions to VmScan #19749

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 22, 2020

Some of the state transitions on error conditions were removed during the prior VmScan refactoring, specifically scan_retry which is called here and abort_retry which is called here

Some of the state transitions on error conditions were removed during
the prior VmScan refactoring, specifically scan_retry and abort_retry.
@miq-bot
Copy link
Member

miq-bot commented Jan 22, 2020

Checked commit agrare@a987cd9 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 2 offenses detected

app/models/vm_scan.rb

@chessbyte chessbyte merged commit cb3eed5 into ManageIQ:master Jan 22, 2020
@agrare agrare deleted the fix_vm_scan_state_transitions branch January 22, 2020 22:45
@agrare agrare added this to the Sprint 129 Ending Feb 3, 2020 milestone Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants