Remove the unsafe cattr_accessor for my_guid_cache #19744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The guid class variable is now wrapped in a mutex, all the methods for accessing the protected data should be wrapped in the same mutex.
|
Extracted this from #19734 |
|
Checked commit carbonin@ea2b71a with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/miq_server.rb
|
|
Applies to ManageIQ/manageiq-pods#353 |
jrafanie
reviewed
Jan 22, 2020
| @@ -19,7 +19,7 @@ | |||
| let(:guid_file) { Rails.root.join("GUID") } | |||
|
|
|||
| it "should return the GUID from the file" do | |||
| MiqServer.my_guid_cache = nil | |||
| MiqServer.my_guid = nil | |||
There was a problem hiding this comment.
To be clear, for future me, the unsafe access, before this change, was that we synchronize around the reads of this value but don't synchronize the writes.
There was a problem hiding this comment.
Well if you use the cattr_accessor it wasn't synchronized at all.
jrafanie
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guid class variable is now wrapped in a mutex, all the methods
for accessing the protected data should be wrapped in the same mutex.