Switch from git source to rubygems.manageiq.org #19564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Dec 2, 2019
bdunne
force-pushed
the
rubygems_manageiq_org
branch
from
ed1ca15 to
8197268
Compare
bdunne
force-pushed
the
rubygems_manageiq_org
branch
from
8197268 to
e66d84d
Compare
|
Checked commit bdunne@e66d84d with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 Gemfile
|
|
cc @simaishi Not sure how this affects the builds. |
|
Since the gem version in this PR differs from what's current set in git based for each gem (thank you for that!), I don't think this switch will cause a problem. |
|
@simaishi I'm also concerned because one of the gems is rugged ,which is a C extension |
That should be ok as we override rugged for downstream build anyway. |
Fryguy
approved these changes
Dec 6, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gems published using: ManageIQ/manageiq-release#103