Look up worker by guid not pid #19557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When each worker is running as a container, each worker gets its own process space meaning it's more than likely that there will by duplicate worker pids for the same server. This would make MiqWorker.my_worker unreliable. This commit saves the worker guid into a class attribute on MiqWorker so that we can access it at any time within the process.
This is needed because MiqQueue.get updates the handler using MiqWorker.my_worker which needs the global guid to be set. Without this the #active_messages relation for the worker record was empty because it joins based on the queue message handler_id
jrafanie
approved these changes
Nov 25, 2019
Fryguy
reviewed
Nov 26, 2019
|
Checked commits carbonin/manageiq@e627261~...18fab45 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
reviewed
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When each worker is running as a container, each worker gets its
own process space meaning it's more than likely that there will
by duplicate worker pids for the same server. This would make
MiqWorker.my_worker unreliable.
This commit saves the worker guid into a class attribute on MiqWorker
so that we can access it at any time within the process.