Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to update additional authentication settings #19525

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Adding ability to update additional authentication settings #19525

merged 1 commit into from
Nov 15, 2019

Conversation

abellotti
Copy link
Member

Adding ability to update the /authentication/mode well as the /authentication/httpd_role via bundle exec rake evm:settings:set

This is needed to allow the Authentication to be configured from the appliance console CLI to SAML/OIDC and Back.

@abellotti
Adding ability to update the /authentication/mode
297ea0f 
as well as the /authentication/httpd_role
via bundle exec rake evm:settings

This is needed to allow the Authentication to be configured
from the appliance console CLI to SAML/OIDC and Back.
@abellotti abellotti mentioned this pull request Nov 15, 2019
Closed
@miq-bot
Copy link
Member

miq-bot commented Nov 15, 2019

Checked commit abellotti@297ea0f with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@miq-bot
Copy link
Member

miq-bot commented Nov 15, 2019

Some comments on commit abellotti@297ea0f

spec/lib/tasks/evm_settings_spec.rb

  • ⚠️ - 23 - Detected puts. Remove all debugging statements.
  • ⚠️ - 24 - Detected puts. Remove all debugging statements.
  • ⚠️ - 47 - Detected puts. Remove all debugging statements.
  • ⚠️ - 48 - Detected puts. Remove all debugging statements.
  • ⚠️ - 71 - Detected puts. Remove all debugging statements.
  • ⚠️ - 72 - Detected puts. Remove all debugging statements.

@abellotti abellotti mentioned this pull request Nov 15, 2019
Merged
@Fryguy Fryguy self-assigned this Nov 15, 2019
@Fryguy Fryguy merged commit 8eea16c into ManageIQ:master Nov 15, 2019
@Fryguy Fryguy added this to the Sprint 125 Ending Nov 25, 2019 milestone Nov 15, 2019
simaishi pushed a commit that referenced this pull request Nov 22, 2019
@Fryguy @simaishi
Merge pull request #19525 from abellotti/support_saml_config
707df01 
Adding ability to update additional authentication settings

(cherry picked from commit 8eea16c)

https://bugzilla.redhat.com/show_bug.cgi?id=1775684
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 707df015e51069da85be3d3de1a95c5b956eae54
Author: Jason Frey <[email protected]>
Date:   Fri Nov 15 17:52:42 2019 -0500

    Merge pull request #19525 from abellotti/support_saml_config

    Adding ability to update additional authentication settings

    (cherry picked from commit 8eea16cac726c480865be23a2747bbd7a60801cd)

    https://bugzilla.redhat.com/show_bug.cgi?id=1775684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

Assignees

@Fryguy Fryguy

Labels
enhancement ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abellotti @miq-bot @simaishi @Fryguy