metrics: set ems in metrics_capture object #19522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2019
|
Checked commit kbrock@9e5742a with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/metric/ci_mixin/capture.rb
|
jrafanie
reviewed
Nov 15, 2019
| if self.kind_of?(ExtManagementSystem) | ||
| self.class::MetricsCapture.new(nil, ext_management_system) | ||
| else | ||
| self.class.parent::MetricsCapture.new(self, ext_management_system) |
There was a problem hiding this comment.
Why is this needed? Is one provider different than another? In what way?
jrafanie
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with azure build failure due to metrics collection.
Details
Each provider's metrics_collection handles the
emsdifferently.I had changed the metrics_capture to have an optional
emsin #19511, to make sure vmware worked: ManageIQ/manageiq-providers-vmware#475 - but this caused issues with azure. Now we're passing inems(in the second branch of theif) so azure and all ems will be happy.Enhancement
The first branch of the
ifenablesEms.perf_capture_object- which is the main purpose of our changes to metrics_collection. This is so metrics can be collected for an ems (rather than for only targets).