Don't convert user-type email to upn

[jvlcek]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769517

Summary:
Fix user_type==mail support in MiqLdap#get_user_object

Details:

The user_type is not always set, requiring MiqLdap#get_user_object to attempt to determine the user_type based on the format of the user_name

The provider VM provisioning screens in the UI provide for the ability to lookup a user by email address in the Idp. The MiqLdap client was erroneously converting the user_type to User Principle Name (UPN) when the username format matched string@string

This PR addresses this issue by:
1 - Explicitly specifying the user-type of mail in MiqRequestWorkflow#retrieve_ldap, which is used by the UI when doing user lookup by email.
2 - Ensuring the user_type is not set to UPN when user_type is mail.

[jvlcek]

@miq-bot add_label wip

[jvlcek]

@miq-bot add_label bug
@miq-bot add_label authentication

[Fryguy]

@jvlcek You have a bad BZ link in the commit and in the OP comment here.

[jvlcek]

Thank you for pointing that out @Fryguy. It should be correct now.

[miq-bot]

Checked commits jvlcek/manageiq@d3fa94b~...8607fae with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

app/models/miq_request_workflow.rb

• ❗ - Line 510, Col 9 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

[chessbyte]

@jvlcek The BZ link above is probably wrong and is unrelated to ManageIQ

[jvlcek]

@chessbyte Thank you. I had fixed that once, not sure how my fix got reverted.

[jvlcek]

@miq-bot remove_label wip

[jvlcek]

I've tested end-to-end against OpenLdap and Active Directory.

[jvlcek]

@gtanzillo Please review.

[jvlcek]

@miq-bot assign @abellotti

[jvlcek]

@hstastna FYI
Thank you for the help with this. Turns out no UI changes will be necessary.

[gtanzillo]

@abellotti This looks good to me. Do you want to give it a look before I merge?