-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] remove deprecation warning #19512
Conversation
The UI still hasn't switched over to using the new method yet so we should probably continue to test the old one for now |
wip until ui is switched |
Didn't you already try this in #19380 ? |
ugh - I hate deprecation warnings. well this one actually passes the tests. so it is better? |
DEPRECATION WARNING: validate_credentials_task is deprecated and will be removed from ManageIQ K-release (use verify_credentials_task instead) (called from block (4 levels) in <top (required)> at spec/models/mixins/authentication_mixin_spec.rb:293)
93f317b
to
8e7fbad
Compare
updated to use |
Checked commit kbrock@8e7fbad with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Until we get the UI off of the old method I think it still has to be tested. |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation. |
Closing, we've removed this deprecation warning |
introduced #19346 fixes:
If you want it solved a different way, just give the word