Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] remove deprecation warning #19512

Closed
wants to merge 1 commit into from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Nov 14, 2019

introduced #19346 fixes:

DEPRECATION WARNING: validate_credentials_task is deprecated and
will be removed from ManageIQ K-release (use verify_credentials_task instead)
(called from block (4 levels) in <top (required)> at
spec/models/mixins/authentication_mixin_spec.rb:293)

If you want it solved a different way, just give the word

@agrare
Copy link
Member

agrare commented Nov 14, 2019

The UI still hasn't switched over to using the new method yet so we should probably continue to test the old one for now

@kbrock kbrock changed the title remove deprecation warning [wip] remove deprecation warning Nov 14, 2019
@kbrock kbrock added the wip label Nov 14, 2019
@kbrock
Copy link
Member Author

kbrock commented Nov 14, 2019

wip until ui is switched

@Fryguy
Copy link
Member

Fryguy commented Nov 14, 2019

Didn't you already try this in #19380 ?

@kbrock
Copy link
Member Author

kbrock commented Nov 14, 2019

ugh - I hate deprecation warnings. well this one actually passes the tests. so it is better?

DEPRECATION WARNING: validate_credentials_task is deprecated and
will be removed from ManageIQ K-release
(use verify_credentials_task instead)
(called from block (4 levels) in <top (required)> at
spec/models/mixins/authentication_mixin_spec.rb:293)
@kbrock kbrock force-pushed the deprecate_validate_creds branch from 93f317b to 8e7fbad Compare January 16, 2020 00:25
@kbrock
Copy link
Member Author

kbrock commented Jan 16, 2020

updated to use klass (less jazz)

@miq-bot
Copy link
Member

miq-bot commented Jan 16, 2020

Checked commit kbrock@8e7fbad with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member

agrare commented Jan 20, 2020

well this one actually passes the tests. so it is better?

Until we get the UI off of the old method I think it still has to be tested.

d-m-u added a commit to d-m-u/manageiq-ui-classic that referenced this pull request Feb 8, 2020
d-m-u added a commit to d-m-u/manageiq-ui-classic that referenced this pull request Feb 8, 2020
@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2020

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

@miq-bot miq-bot added the stale label Jun 11, 2020
@gtanzillo
Copy link
Member

Closing, we've removed this deprecation warning

@gtanzillo gtanzillo closed this Jul 20, 2020
@kbrock kbrock deleted the deprecate_validate_creds branch July 28, 2020 13:17
@kbrock kbrock removed the stale label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants