metrics capture gap by ems #19506
Merged
metrics capture gap by ems #19506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
kicking |
kbrock
force-pushed
the
cu_capture_gap
branch
from
5fe1fb6 to
5348628
Compare
kbrock
force-pushed
the
cu_capture_gap
branch
from
5348628 to
6ca72b2
Compare
kbrock
force-pushed
the
cu_capture_gap
branch
from
6ca72b2 to
26368fb
Compare
|
rebased to fix merge conflict |
|
kicking |
kbrock
force-pushed
the
cu_capture_gap
branch
3 times, most recently
from
7d5bbdf to
ecbe43e
Compare
currently the ui sends a zone to collect metric gaps this allows the ui to transition from zone to ems
kbrock
force-pushed
the
cu_capture_gap
branch
from
ecbe43e to
e103374
Compare
|
helped rubocop with fixing up the tools/metrics_capture_gap |
kbrock
force-pushed
the
cu_capture_gap
branch
from
e103374 to
b6c9b62
Compare
update callers of perf_capture_gap to also support ems_id
kbrock
force-pushed
the
cu_capture_gap
branch
from
b6c9b62 to
2fa123c
Compare
|
Checked commits kbrock/manageiq@25ca045~...2fa123c with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #19492. This is part of the initiative towards ems centric collection (vs zone).
before
after
queue_captures, the same method that regular metrics is done.note: Since there is typically 1 ems per zone, this change is pretty much a tomato/potatoe kind of thing. (But being ems centric buys us things down the line)