Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MiqExpression#registry_data and add coverage #19497

Merged
merged 4 commits into from
Nov 13, 2019

Conversation

lpichler
Copy link
Contributor

@miq-bot add_label refactoring

@miq-bot assign @kbrock

@miq-bot
Copy link
Member

miq-bot commented Nov 12, 2019

Checked commits lpichler/manageiq@61f0a9c~...f54bfae with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@lpichler lpichler closed this Nov 13, 2019
@lpichler lpichler reopened this Nov 13, 2019
Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this code.

but your changes are an improvement

@kbrock kbrock merged commit 72ffca2 into ManageIQ:master Nov 13, 2019
@kbrock kbrock added this to the Sprint 125 Ending Nov 25, 2019 milestone Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants