Use the workers proc rather than overriding the method #19494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit fefccb6 caused us to start metrics collector workers even if the role was not active. This fixes that issue and adds tests to the `.workers` method for the PerEmsTypeWorkerMixin
carbonin
force-pushed
the
start_correct_metrics_workers
branch
from
c2f8feb to
47c3ddb
Compare
|
Checked commit carbonin@47c3ddb with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Wow, good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fefccb6 caused us to start metrics collector workers even if the role was not active.
This fixes that issue and adds tests to the
.workersmethod for thePerEmsTypeWorkerMixin