Optionally symlink a plugin's spec/manageiq #19481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fryguy figured we could work out how the generator should look then I'll blast out the rest of the plugins from this |
Fryguy
reviewed
Nov 7, 2019
agrare
force-pushed
the
optionally_symlink_spec_manageiq_in_plugins
branch
from
1b3bced to
d330e4b
Compare
agrare
commented
Nov 7, 2019
agrare
force-pushed
the
optionally_symlink_spec_manageiq_in_plugins
branch
from
d330e4b to
ddd1323
Compare
Add the option to symlink a plugin's spec/manageiq instead of a shallow clone, allowing for local repositories to be linked together to test groups of changes.
Fryguy
reviewed
Nov 7, 2019
|
Checked commits agrare/manageiq@ddd1323~...e21c51f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Some comments on commits agrare/manageiq@ddd1323~...e21c51f lib/generators/manageiq/plugin/templates/bin/setup
|
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to symlink a plugin's spec/manageiq instead of a shallow
clone, allowing for local repositories to be linked together to test
groups of changes.