-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable workers as containers #19451
Enable workers as containers #19451
Conversation
@Fryguy I can contain the last commit to a hack in the containers code, but I figured this is probably the way it should have worked either way. |
Have you verified that the existing non-container worker management still works as expected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, with a few questions/comments.
This reverts commit 8467e94.
Artemis is not being used anymore and ENV["DATABASE_SERVICE_NAME"] is not set on the orchestrator pod.
This makes it easier for developers to specify alternate namespaces and registries for the worker images. The orchestrator will be provided the value as a part of the deploy process and will pass it along to all the worker deployments
Previously MiqWorker.workers would return the configured count even if the required roles for the worker type were not met.
Yup. |
Checked commits carbonin/manageiq@9d279ed~...469f730 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
This PR reverts the commit which disabled workers to be run as containers in OpenShift.
It also removes some information around artemis which is no longer planned to be used and fixes some additional bugs.
Notably it changes the
MiqWorker.workers
method to return a count of 0 when we are missing a required role for the specific worker type. Previously this method would return the configured type regardless of the roles on the server. In OpenShift, this will allow us to scale down workers