Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of gems for AWS SDK usage #19436

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Reduce the number of gems for AWS SDK usage #19436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ gem "activerecord-virtual_attributes", "~>1.4.0"
gem "activerecord-session_store", "~>1.1"
gem "acts_as_tree", "~>2.7" # acts_as_tree needs to be required so that it loads before ancestry
gem "ancestry", "~>3.0.7", :require => false
gem "aws-sdk-ec2", "~>1.0", :require => false # For FileDepotS3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fryguy FileDepotS3 shouldn't need ec2 though, right?

Copy link
Member

@NickLaMuro NickLaMuro Oct 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this seems wrong:

manageiq/app/models/file_depot_s3.rb

Lines 65 to 69 in b5c6cd2

def translate_exception(err)
require 'aws-sdk-ec2'
case err
when Aws::EC2::Errors::SignatureDoesNotMatch

Going to investigate...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible that the code just used Aws::EC2::Errors, but those errors are available elsewhere (perhaps in Aws::S3)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have created a PR to address this here:

#19439

Pretty sure the DynamicErrors should be defining these under the Aws::S3 name space, but wouldn't mind a second set of eyes.

gem "aws-sdk-s3", "~>1.0", :require => false # For FileDepotS3
gem "bcrypt", "~> 3.1.10", :require => false
gem "bundler", ">=1.15", :require => false
gem "byebug", :require => false
Expand Down