Cu schedule collector by ems #19420
Merged
Cu schedule collector by ems #19420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
cu_schedule_ems
branch
2 times, most recently
from
31908f1 to
3f58c9a
Compare
agrare
reviewed
Oct 24, 2019
kbrock
force-pushed
the
cu_schedule_ems
branch
2 times, most recently
from
1d6a3f2 to
f0ea15e
Compare
schedules_for_ems_metrics_coordinator_role checks for role enabled with ems_metrics_coordinator before creating repeating timer metric_capture_perf_capture_timer No need to also check for the the role in the timer
kbrock
force-pushed
the
cu_schedule_ems
branch
from
f0ea15e to
d253be7
Compare
Fryguy
reviewed
Oct 28, 2019
|
One issue from me on the terminology, but otherwise looks good. I'll leave it to @agrare to merge |
kbrock
force-pushed
the
cu_schedule_ems
branch
from
d253be7 to
42424ae
Compare
Merged
agrare
reviewed
Oct 29, 2019
| @@ -68,11 +68,11 @@ def storage_scan_timer | |||
| end | |||
|
|
|||
| def metric_capture_perf_capture_timer | |||
| zone = MiqServer.my_server(true).zone | |||
| if zone.role_active?("ems_metrics_coordinator") | |||
| MiqServer.my_server.zone.ems_collectable.each do |ems| | |||
There was a problem hiding this comment.
I think you missed updating this one to ems_metrics_collectable
Up until now, perf_capture_timer is never passed a parameter So changing the parameter from zone to ems_id will not break anything.
kbrock
force-pushed
the
cu_schedule_ems
branch
from
42424ae to
6af789d
Compare
|
Checked commits kbrock/manageiq@16aec34~...6af789d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We suggest that customers should configure one ems per zone.
So running collection by zone is typically just running collection by ems.
before
scheduler sends no parameter for collector.
collector defaults to the current zone
collector gets all vms/hosts for the zone and sends off a message to collect each.
after
scheduler sends an ems for collector
collector gets all vms/hosts for the ems and sends off a message to collect each.
old messages for collectors still default to the current zone.
/thanks @d-m-u