Fixed sorting in TenantQuotas report #19415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot remove-label changelog/no |
|
@miq-bot add-label changelog/yes |
yrudman
changed the title
yrudman
force-pushed
the
add-virtual-column-tenant-quote-description
branch
from
00a615c to
7a976ba
Compare
yrudman
changed the title
…nantQuota report replaces Db value with human readable and translated value,Example: cpu_allocated will be shown as "Allocated Virtual CPUs". BUT sorting by quota_name column done before substitution and result looks like bug in sorting. Fix: instead of TenanatQuota#name field use in report virtual column TenanatQuota#description which will show substituted value Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1761430
yrudman
force-pushed
the
add-virtual-column-tenant-quote-description
branch
from
7a976ba to
cded423
Compare
|
Checked commits yrudman/manageiq@28e48f8~...cded423 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lpichler Libor, could you review |
|
thank you @kbrock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: quota names saved in Db are not descriptive and not translated. So, TenantQuota report replaces Db value with human readable and translated value.
Example:
cpu_allocatedwill be shown asAllocated Virtual CPUs.BUT sorting by
quota_namecolumn was executed before substitution and final result looks in strange order.Fix: Introduce virtual column
TenantQuota#descriptionand use it in report instead ofTenanatQuota#nameso sorting will be executed on actual visible stringsFixes https://bugzilla.redhat.com/show_bug.cgi?id=1761430
BEFORE:
AFTER:
@miq-bot add-label bug, reporting, ivanchuk/yes, changelog/no