Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sys-filesystem gem to 1.3.1 #19399

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Update sys-filesystem gem to 1.3.1 #19399

merged 1 commit into from
Oct 15, 2019

Conversation

djberg96
Copy link
Contributor

This PR updates the sys-filesystem gem to version 1.3.1. This version includes fixes for Linux (and BSD), and all adds mount and umount singleton methods that we could potentially use in the future instead of shelling out.

@djberg96
Copy link
Contributor Author

@miq-bot add_label hammer/no, ivanchuk/no

@miq-bot
Copy link
Member

miq-bot commented Oct 15, 2019

Checked commit https://github.com/djberg96/manageiq/commit/0c3b467d9d775f978eb8878b1267373f12405f69 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, afaik we only use this on core so I think it's safe to just merge

@jrafanie jrafanie self-assigned this Oct 15, 2019
@jrafanie jrafanie merged commit 67ffa17 into ManageIQ:master Oct 15, 2019
@jrafanie jrafanie added this to the Sprint 123 Ending Oct 28, 2019 milestone Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants