fix schedule_settings #19386
Merged
fix schedule_settings #19386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We refactored an overshadowing variable, but we didn't fix all references to that variable introduced in 93d5f5d
|
Checked commit kbrock@18e5980 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
djberg96
approved these changes
Oct 10, 2019
|
@Fryguy can we backport this to ivanchuk? |
Fryguy
added a commit
that referenced
this pull request
May 25, 2021
fix schedule_settings (cherry picked from commit bc374f4)
|
|
|
cc @simaishi @dmetzger57 on the backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We refactored an overshadowing variable, but we didn't fix
all references to that variable.
introduced in 93d5f5d #18660
This bug has not been reported