Set default OrchestrationTemplateRunner timeout to 100 minutes. #19381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lfu Cannot apply the following label because they are not recognized: service |
jrafanie
reviewed
Oct 10, 2019
| @@ -1,5 +1,5 @@ | |||
| class ManageIQ::Providers::CloudManager::OrchestrationTemplateRunner < ::Job | |||
| DEFAULT_EXECUTION_TTL = 10 # minutes | |||
| DEFAULT_EXECUTION_TTL = 100 # minutes | |||
There was a problem hiding this comment.
Can you change this constant name to include minutes, perhaps DEFAULT_EXECUTION_TTL_MINUTES? We generally try to store the base unit of measure: seconds, bytes, etc. I would not expect this to be in minutes.
lfu
force-pushed
the
orch_stack_timeout_1756292
branch
from
6317702 to
c5e2dc1
Compare
|
Checked commit lfu@c5e2dc1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manageiq/providers/cloud_manager/orchestration_template_runner.rb
|
jrafanie
reviewed
Oct 14, 2019
|
|
||
| def minimize_indirect | ||
| @minimize_indirect = true if @minimize_indirect.nil? | ||
| @minimize_indirect | ||
| end | ||
|
|
||
| def current_job_timeout(_timeout_adjustment = 1) | ||
| @execution_ttl ||= | ||
| (options[:execution_ttl].present? ? options[:execution_ttl].try(:to_i) : DEFAULT_EXECUTION_TTL) * 60 | ||
| @execution_ttl ||= options[:execution_ttl].present? ? options[:execution_ttl].to_i.minutes : DEFAULT_EXECUTION_TTL |
There was a problem hiding this comment.
This makes a lot more sense to me, thanks @lfu
|
@lfu Can this be |
|
@simaishi Yes. |
simaishi
pushed a commit
that referenced
this pull request
Jan 7, 2021
Set default OrchestrationTemplateRunner timeout to 100 minutes. (cherry picked from commit b61deda) https://bugzilla.redhat.com/show_bug.cgi?id=1756292
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the default automate timeout.
https://bugzilla.redhat.com/show_bug.cgi?id=1756292
@miq-bot assign @tinaafitz
@miq-bot add_label bug, services