[V2V] Remove removing_snapshots state #19374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
Checked commit fabiendupont@62d3b49 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Oct 7, 2019
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Nov 4, 2019
…hots_state [V2V] Remove removing_snapshots state (cherry picked from commit 24719d4) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768531
|
Ivanchuk backport details: |
simaishi
added a commit
that referenced
this pull request
Dec 3, 2019
…ve_snapshots_state" This reverts commit 2c5781e. https://bugzilla.redhat.com/show_bug.cgi?id=1768531
|
Temporarily reverted backport as this causes conflicts reverting other PRs. |
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
…hots_state [V2V] Remove removing_snapshots state (cherry picked from commit 24719d4) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768531
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User feedback is that snapshots should not be removed during migration to allow a complete rollback in case of failure. Previously, we considered that virt-v2v could not convert a VM with snapshots, so we forcefully removed existing snapshots. But this assumption is wrong.
This PR removes the
removing_snapshotsstate and adjusts the transitions.RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1759147