[V2V] Extend InfraConversionJob timeout #19373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Oct 7, 2019
app/models/infra_conversion_job.rb
Outdated
| @@ -1,4 +1,7 @@ | |||
| class InfraConversionJob < Job | |||
| # Override default timeout to allow large disks VM migration | |||
| DEFAULT_TIMEOUT = 36.hours | |||
There was a problem hiding this comment.
Prefer overriding the self.current_job_timeout method instead of redefining the constant
|
Checked commits fabiendupont/manageiq@1ff088e~...e701a4a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Oct 7, 2019
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
…ionjob_timeout [V2V] Extend InfraConversionJob timeout (cherry picked from commit 584f8bc) https://bugzilla.redhat.com/show_bug.cgi?id=1789433
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InfraConversionJob class inherits from Job class. And Job class implements a timeout mechanism with a default timeout of 5 minutes. A VM migration is likely to take more than 5 minutes, so this PR sets the
DEFAULT_TIMEOUTconstantself.current_job_timeoutmethod to 36 hours to allow large VM to migrate.RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1759062