Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default_value_for rails 5.2/6 support #19370

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Oct 4, 2019

3.1.0 supports rails 5.2
3.2.0 adds better rails 5.1 AC Parameter support
3.3.0 adds rails 6 support

Note, ChrisA helps to maintain this gem and it has been largely in maintenance mode so I feel good letting minor versions increment.

  • Requires passing cross-repo tests here
  • (NOTE: nuage is expected to fail because the cross repo build tool can't support repos with custom setups such as nuage because it custom installs qpid_proton)
  • vmware failure is now fixed

3.1.0 supports rails 5.2
3.2.0 adds better rails 5.1 AC Parameter support
3.3.0 adds rails 6 support
@miq-bot
Copy link
Member

miq-bot commented Oct 4, 2019

Checked commit jrafanie@b5abb6e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@kbrock kbrock self-assigned this Oct 4, 2019
@kbrock kbrock added this to the Sprint 122 Ending Oct 14, 2019 milestone Oct 4, 2019
@kbrock
Copy link
Member

kbrock commented Oct 5, 2019

@jrafanie nuage is understandable.

What about the vmware one - the vcr failure looks unrelated to me but I'm unsure
(I don't have privs to kick vmware other wise I'd restart it (thought I think you already tried this)

@agrare
Copy link
Member

agrare commented Oct 7, 2019

@jrafanie @kbrock VMware was failing because we released a new version of the gem and the PR to the provider wasn't merged right away. Should be fixed now.

@jrafanie
Copy link
Member Author

jrafanie commented Oct 7, 2019

@jrafanie @kbrock VMware was failing because we released a new version of the gem and the PR to the provider wasn't merged right away. Should be fixed now.

thanks, I'm finally getting to this.... I kicked the vmware provider to see if it now passes.

@jrafanie
Copy link
Member Author

jrafanie commented Oct 7, 2019

thanks, I'm finally getting to this.... I kicked the vmware provider to see if it now passes.

Awesome, we're all green except for nuage, which is expected since cross repo can't test that.

@kbrock kbrock merged commit b601926 into ManageIQ:master Oct 7, 2019
@jrafanie jrafanie deleted the upgrade_default_value_for_4_rails_5_2_and_6_0_support branch October 7, 2019 19:12
@chessbyte chessbyte mentioned this pull request Mar 31, 2020
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants