Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit arel delegation is deprecated, make it explicit (rails 5.2) #19369

Merged

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Oct 4, 2019

Implicit arel delegation is deprecated.

Fixes an annoying warning:

DEPRECATION WARNING: Delegating exists to arel is deprecated and will be removed in Rails 6.0. (called from with_any_tags at /Users/joerafaniello/Code/manageiq/lib/extensions/ar_taggable.rb:56)

Implicit arel delegation is deprecated.

Fixes an annoying warning:

DEPRECATION WARNING: Delegating exists to arel is deprecated and will be removed in Rails 6.0. (called from with_any_tags at /Users/joerafaniello/Code/manageiq/lib/extensions/ar_taggable.rb:56)
@miq-bot
Copy link
Member

miq-bot commented Oct 4, 2019

Checked commit jrafanie@2f1ec8f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh. original code is questionable. (please don't git blame)

LGTM

@kbrock kbrock merged commit 594ed6e into ManageIQ:master Oct 4, 2019
@kbrock kbrock added this to the Sprint 122 Ending Oct 14, 2019 milestone Oct 4, 2019
@kbrock kbrock self-assigned this Oct 4, 2019
@jrafanie jrafanie deleted the make_implicit_arel_delegation_explicit branch October 4, 2019 19:46
@chessbyte chessbyte mentioned this pull request Mar 31, 2020
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants