Convert unsafe SQL to pure active record methods (rails 5.2) #19366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
requested changes
Oct 4, 2019
kbrock
force-pushed
the
wrap_known_safe_SQL_in_arel_sql
branch
from
ab1758a to
a147213
Compare
kbrock
approved these changes
Oct 4, 2019
kbrock
changed the title
DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "storage_id, COUNT(*) AS vm_count". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql(). --- Since the order is a standard query, using order(:timestamp) passing :timestamp => "DESC" is the same thing in descending order group.count is a count for nodes with a group by
kbrock
force-pushed
the
wrap_known_safe_SQL_in_arel_sql
branch
from
a147213 to
eb3e88d
Compare
|
Checked commit jrafanie@eb3e88d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Merging Keenan's code on my PR 🤣 |
|
<3 thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "storage_id, COUNT(*) AS vm_count". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql().